-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make V0EventSelector
produce skimmed V0 collections based on their mass
#46005
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46005/41788 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
f47b3b0
to
43db8e1
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46005/41791 |
Pull request #46005 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
Hi @mmusich, This PR has been tested on DQM playback machine with 14_0_15_patch1 and run 385627. All clients ended gracefully. For more information please refer to DQM^2 mirror logs here: https://cmsweb.cern.ch/dqm/dqm-square/?run=518657&db=playback Please note that this PR is tested on 14_0_15_patch1 instead of the targeted 14_2_X. Best regards, |
Hi @vicha-w
thanks, though this wasn't really necessary, see PR description:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all, it was suggested to modify
V0EventSelector
in order to produce skimmed V0 collections based on their mass, to enhance the purity in terms of strange origin of the tracks analyzed viaStandaloneTrackMonitor
, based on the results shown here and here.This update concerns only the Tracking Data/MC validation suite and is of no consequence on any DQM production sequence run in online or offline DQM.
PR validation:
Relies on the existing unit tests of this package:
scram b runtests_testTrackingDATAMC
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, might be backported later on for convenience